added fix to allow usage of uppercase letters #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danail-branekov
approved these changes
Apr 10, 2024
danail-branekov
force-pushed
the
issue-3210
branch
from
2bbd3c5 to
4066e33
Compare
danail-branekov
force-pushed
the
issue-3210
branch
from
4066e33 to
318e022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3210
What is this change about?
We want to allow users to define CF Routes with uppercase letters and still have them Work. This is required for CATS compatibility.
Does this PR introduce a breaking change?
not that I have seen or that it would be expected.
Acceptance Steps
cf create-route apps-127-0-0-1.nip.io --hostname TEST123
should work and create a valid HTTPRoute like: test123.apps-127-0-0-1.nip.io
Tag your pair, your PM, and/or team
@danail-branekov @georgethebeatle