Fix GetDeletedAt for orgs #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GetDeletedAt method now delegates to GetOrg. This is important since orgs are special from rbac point of view since in order to know if we have permission in an org we have to have role bindings to some role in that org. This is why GetOrg is implemented via List-ing orgs and filtering by guid. Not following that pattern results in any user seeing any orgs. Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
gcapizzi
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2605
What is this change about?
The GetDeletedAt method now delegates to GetOrg. This is important since
orgs are special from rbac point of view since in order to know if we
have permission in an org we have to have role bindings to some role in
that org. This is why GetOrg is implemented via List-ing orgs and
filtering by guid. Not following that pattern results in any user seeing
any orgs.
Does this PR introduce a breaking change?
No
Acceptance Steps
See #2605 (comment)
Tag your pair, your PM, and/or team
@gcapizzi