Return valid CF 404 errors #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieron-dev
force-pushed
the
2292-not-found
branch
from
d191fd9 to
02132d5
Compare
Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
Issue: #2292 Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com>
gcapizzi
force-pushed
the
2292-not-found
branch
from
02132d5 to
ae2ff8e
Compare
kieron-dev
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2292
What is this change about?
This adds support for custom 404 and 405 handlers to our
routingpackage. It then uses it to return well-formed CF errors.Does this PR introduce a breaking change?
The format of 404 and 405 errors will now be compatible with CF.
Tag your pair, your PM, and/or team
@kieron-dev