Cleanup old packages in package reconciler #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieron-dev
force-pushed
the
issues/2232-delete-older-packages
branch
from
cc2cfa1 to
69d8e0e
Compare
kieron-dev
force-pushed
the
issues/2232-delete-older-packages
branch
from
69d8e0e to
1bc6aa4
Compare
gcapizzi
approved these changes
Mar 20, 2023
kieron-dev
force-pushed
the
issues/2232-delete-older-packages
branch
from
1bc6aa4 to
35f8784
Compare
Here we also stop using the patching reconciler in the package reconciler as it produced flaky behaviour. Instead we save status or the main resource as required. This introduces a new config value `MaxRetainedPackagesPerApp` in the controllers config, and a corresponding value in the controllers section of the helm values `maxRetainedPackagesPerApp`. Issue: #2232 Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com> Co-authored-by: Kieron Browne <kbrowne@vmware.com>
kieron-dev
force-pushed
the
issues/2232-delete-older-packages
branch
from
35f8784 to
f48faf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2232
What is this change about?
Automatically delete packages with uploaded sources, retaining the package associated with the app's current droplet, and N more, in order of creation date.
Does this PR introduce a breaking change?
New controllers config map value
maxRetainedPackagesPerApp.Acceptance Steps
See story
Tag your pair, your PM, and/or team
@gcapizzi