Update log levels #2244
Merged
Update log levels #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clintyoshimura @Birdrock did y'all have any thoughts on the log level used by the new logErrorAndSetReadyStatus helper function? We considered moving the logs down to Info level given the additional error handling of the ready status in the api layer, but wanted to check with y'all first. |
acosta11
force-pushed
the
issues/1926
branch
2 times, most recently
from
59e21af to
acc1da4
Compare
kpack-image-builder/controllers/imageprocessfetcher/image_process_fetcher.go
Outdated
Show resolved
Hide resolved
controllers/controllers/services/cfservicebinding_controller.go
Outdated
Show resolved
Hide resolved
- Use error log level for platform startup issues, debug log level for resource lifecycle events and info log level for everything else. - Attach an error to an info log entry as a "reason" if appropriate. - Default to info logs for errors in controllers that also set status condition - Make capitalization consistent for log messages (only capitalize kubernetes resource names) Co-authored-by: Matt Royal <mroyal@vmware.com> Co-authored-by: Dave Walter <walterda@vmware.com> Co-authored-by: Ashwin Krishna <krishnaas@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#1926
What is this change about?
Audit and update all existing logs to an appropriate level. We generally did the following to logs:
Note that after rebasing on main there is a new helper function that is logging at the error level. We left the helper alone for now and will confirm with the team whether there is any issue with moving that down to info by default, potentially with a sibling helper function.Updated the new helper function to info log level like the rest of the controller logs returning errors back to the api.
Does this PR introduce a breaking change?
No
Acceptance Steps
Deploy Korifi normally and see many fewer noisy logs at the default log level.
Tag your pair, your PM, and/or team
@davewalter @matt-royal
cc @julian-hj for thoughts