This repository was archived by the owner on May 31, 2023. It is now read-only.
Few smaller improvements, backward compatible #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krzyzakp
commented
Nov 9, 2018
krzyzakp
commented
- Fixed running role in check_mode, so it's not failing anymore
- Added environment param for getting GPG key and installing Grafana - usefull, when you have to use PROXY
- Added option to disable managing dashboards. Useful when you modify them manually via web interface.
added 7 commits
November 7, 2018 16:52
…, to include service name, for better handling with other roles
…an set ie. http_proxy for getting GPG key. Added possibility to skip managing dashboards.
paulfantom
reviewed
Nov 9, 2018
README.md
Outdated
| @@ -49,9 +49,11 @@ All variables which can be overridden are stored in [defaults/main.yml](defaults | |||
| | `grafana_tracing` | {} | [tracing](http://docs.grafana.org/installation/configuration/#tracing) configuration section | | |||
| | `grafana_snapshots` | {} | [snapshots](http://docs.grafana.org/installation/configuration/#snapshots) configuration section | | |||
| | `grafana_image_storage` | {} | [image storage](http://docs.grafana.org/installation/configuration/#external-image-storage) configuration section | | |||
| | `grafana_manage_dashboards` | true | Defines if dashboards should be managed by Ansible (will overwrite exisiting) | | |||
There was a problem hiding this comment.
This seems unnecessary and a bit redundant. Why not check for grafana_dashboards | length > 0 and if there are any "{{ grafana_dashboards_dir }}/*.json ?
|
This is great, could you rebase to fix git conflicts? |
|
Merge conflicts resolved. |
dimavin
pushed a commit
to intento/ansible-grafana
that referenced
this pull request
Jan 16, 2019
* Replaced tag always, which colidate when including role. Renamed tags, to include service name, for better handling with other roles * Updating molecule command, basing on official docs for latest version * Installing older pytest, which is not broken * Fixed module name typo * Fixed check_mode, to work smoothly. Added environment param, so you can set ie. http_proxy for getting GPG key. Added possibility to skip managing dashboards. * Fixed skipping environment when not setup * Updated README with new configuration params * Removed unnecessary variable for managing dashboards * Fixed pattern for templates
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.