Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch arm64 tests to self-hosted GitHub Actions runner #316

Merged
merged 4 commits into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
build:
if: github.event_name == 'pull_request'
name: Build
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
strategy:
fail-fast: false
matrix:
Expand All @@ -21,7 +21,7 @@ jobs:
tests: false
steps:
- name: Code checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install Rust toolchain
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docker-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ env:

jobs:
main:
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- name: Code checkout
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Set up QEMU
uses: docker/setup-qemu-action@v2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
release:
if: github.event_name == 'create' && github.event.ref_type == 'tag'
name: Release
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- name: Code checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install Rust toolchain
Expand Down
15 changes: 11 additions & 4 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,24 @@ on: [pull_request, create]
jobs:
build:
name: Tests
runs-on: ubuntu-22.04
runs-on: ${{ matrix.runner }}
strategy:
fail-fast: false
matrix:
include:
- runner: ubuntu-22.04
coreboot-tests: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind doing something like variant: coreboot here and something like variant: no coreboot - will produce nicer actions titles - otherwise - nice use of matrix!

- runner: focal-arm64
coreboot-tests: false
steps:
- name: Code checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Run unit tests
run: scripts/dev_cli.sh tests --unit
- name: Run integration tests
run: scripts/dev_cli.sh tests --integration
- name: Run integration tests
run: scripts/dev_cli.sh tests --integration-coreboot
- if: ${{ matrix.coreboot-tests }}
name: Run coreboot integration tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this - I saw this the other day when I was reviewing the output.

run: scripts/dev_cli.sh tests --integration-coreboot
23 changes: 0 additions & 23 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,29 +31,6 @@ pipeline {
}
}
}
stage ('AArch64 Tests') {
agent { node { label 'focal-arm64' } }
stages {
stage ('Checkout') {
steps {
checkout scm
}
}
stage('Run unit tests') {
steps {
sh "scripts/dev_cli.sh tests --unit"
}
}
stage('Run integration tests') {
options {
timeout(time: 1, unit: 'HOURS')
}
steps {
sh "scripts/dev_cli.sh tests --integration"
}
}
}
}
}
}
}
Expand Down