Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance parentheses #468

Merged
merged 1 commit into from
Apr 4, 2020
Merged

Balance parentheses #468

merged 1 commit into from
Apr 4, 2020

Conversation

prertik
Copy link
Contributor

@prertik prertik commented Apr 4, 2020

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • The new code is not generating byte compile warnings (run cask exec emacs -batch -Q -L . -eval "(progn (setq byte-compile-error-on-warn t) (batch-byte-compile))" clj-refactor.el)
  • All tests are passing (run ./run-tests.sh)
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@prertik
Copy link
Contributor Author

prertik commented Apr 4, 2020

Before, applying my commit, I noticed the tests weren't running because of unbalanced parentheses.
Now, the tests fail at: Scenario: Move forms does not create circular dependencies, #341. I think this is related to issue #467. @bbatsov

@bbatsov bbatsov merged commit 7ab3e21 into clojure-emacs:master Apr 4, 2020
@bbatsov
Copy link
Member

bbatsov commented Apr 4, 2020

Ops, my bad! Thanks for fixing my mistake! That's what happens when you just commit away without testing at all. :D My guess is that #467 was actually caused by the broken code, we'll see about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants