Skip to content

[bug]: notation.lua is missing from the rockspec #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tieske opened this issue Nov 26, 2024 · 5 comments · Fixed by #39
Closed

[bug]: notation.lua is missing from the rockspec #38

Tieske opened this issue Nov 26, 2024 · 5 comments · Fixed by #39

Comments

@Tieske
Copy link
Contributor

Tieske commented Nov 26, 2024

The file is in the repo, but not in the rockspec, so won't get installed.
Tieske added a commit to Tieske/xmlua that referenced this issue Nov 26, 2024
@Tieske
fix(rockspec): include 'notation.lua'
0bf69ae 
fixes: clear-code#38
Tieske added a commit to Tieske/xmlua that referenced this issue Nov 26, 2024
@Tieske
fix(rockspec): include 'notation.lua'
d626970 
fixes: clear-code#38
@Tieske
Copy link
Contributor Author

Tieske commented Nov 26, 2024

fix is in #37

@kou
Copy link
Member

kou commented Nov 26, 2024

Could you open a separated PR instead of adding unrelated changes to one PR?

Tieske added a commit to Tieske/xmlua that referenced this issue Nov 27, 2024
@Tieske
fix(rockspec): include 'notation.lua'
0ac75d2 
fixes: clear-code#38
@Tieske Tieske mentioned this issue Nov 27, 2024
Merged
kou pushed a commit that referenced this issue Nov 27, 2024
@Tieske
fix(rockspec): include 'notation.lua' (#39)
c3bf1dd 
fixes: #38
@kou kou closed this as completed in #39 Nov 27, 2024
@Tieske
Copy link
Contributor Author

Tieske commented Nov 27, 2024

#39 is now a separate PR for this. It is related however, since #37 fails hard without this fix.

@kou
Copy link
Member

kou commented Nov 27, 2024

I've merged #39. Could you rebase #37 on master?

@Tieske
Copy link
Contributor Author

Tieske commented Nov 27, 2024

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rockspec): include 'notation.lua' Tieske/xmlua
2 participants
@kou @Tieske