Add #ifdef BH1750_DEBUG guards around all serial print statements
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l terminal when not debugging BH1750
QuentinTorg
commented
Aug 18, 2023
| break; | ||
| #endif | ||
| // out of range input, safe to return early | ||
| return false; |
There was a problem hiding this comment.
This is maybe out of place in this PR. I can move it if preferred.
This exits early in the case that nothing was sent over the bus. If nothing was sent then there is no need to check for an ACK or print another error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were already
#ifdefmacros wrapping some of the serial print statements in the library. This PR adds macros around the remaining Serial print statements.The serial print statements can be very noisy. They are helpful when debugging the BH1750, but for some use cases this can be extremely overwhelming. This is particularly hard to deal with when using serial prints to debug other sensors without the BH1750 sensor connected