Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve simulation handling for tax transactions #504

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

StrathCole
Copy link
Collaborator

Summary of changes

Currently simulations do not take into account any burn tax split operations.
This has been like this since that feature was introduced long ago. We found out that this has a significant influence on estimated gas, so makes estimations less reliable.
This fix aims to make a non-state-breaking change that only endpoints need to install which are queried for simulation (gas estimation).

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@StrathCole StrathCole requested a review from fragwuerdig July 30, 2024 14:36
Copy link
Collaborator

@fragwuerdig fragwuerdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good optional Install for endpoints. Thx 👌

@StrathCole StrathCole merged commit c8c04d9 into main Jul 30, 2024
22 checks passed
@StrathCole StrathCole deleted the strath/simulate-fix branch July 30, 2024 19:47
@StrathCole StrathCole restored the strath/simulate-fix branch August 1, 2024 16:06
@inon-man inon-man deleted the strath/simulate-fix branch August 3, 2024 01:42
@inon-man inon-man restored the strath/simulate-fix branch August 3, 2024 01:43
@inon-man inon-man deleted the strath/simulate-fix branch August 3, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants