Improve simulation handling for tax transactions #504
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Currently simulations do not take into account any burn tax split operations.
This has been like this since that feature was introduced long ago. We found out that this has a significant influence on estimated gas, so makes estimations less reliable.
This fix aims to make a non-state-breaking change that only endpoints need to install which are queried for simulation (gas estimation).
Report of required housekeeping
(FOR ADMIN) Before merging