[3415763] Fixed duplicated 'main-content' element is printed on the page. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-salsadigital
added
the
PR: Needs review
| @@ -41,7 +41,6 @@ | |||
|
|
|||
| {% if content or sidebar %} | |||
| <main class="ct-layout {{ modifier_class }}" role="main"> | |||
| <a id="main-content" tabindex="-1"></a> | |||
There was a problem hiding this comment.
Removed from here as its added
https://github.com/civictheme/uikit/blob/main/components/04-templates/page/page.twig#L52
As element with the ID main-content is placed at the top of the document, and it's followed by the
element, which wraps around the main content area.
AlexSkrypnyk
added
PR: DO NOT MERGE
|
We need to wait for a11y review of the solution. Question posted to #100 |
joshua-salsadigital
added
PR: Needs review
AlexSkrypnyk
approved these changes
Mar 14, 2024
AlexSkrypnyk
deleted the
feature/3415763-fix-duplicate-main-content-element
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #100
Checklist before requesting a review
as
[#123] Verb in past tense with a period at the end.Changedsection about WHY something wasdone if this was a bespoke implementation.
and they have passed.
Changed
Screenshots