Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC: Fixed navigation menu when 'Dropdown type is set to 'None'. #94

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Mar 6, 2024

closes #96

https://www.drupal.org/project/civictheme/issues/3422805

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Updated navigation to remove child items when dropdown is set to none.
  2. Added missing styles for navigation when when dropdown is set to none.

Screenshots

Before:
Screenshot 2024-03-06 at 11 53 12 AM

After:
Screenshot 2024-03-06 at 11 54 43 AM

@joshua-salsadigital joshua-salsadigital added the PR: Needs review Pull request needs a review from assigned developers label Mar 6, 2024
@joshua-salsadigital joshua-salsadigital self-assigned this Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

@github-actions github-actions bot temporarily deployed to pull request March 6, 2024 06:24 Inactive
@AlexSkrypnyk AlexSkrypnyk changed the title Issue #3422805 by joshua1234511: Fixed navigation menu when 'Dropdown type; is set to 'None'. Issue #3422805 by joshua1234511: Fixed navigation menu when 'Dropdown type is set to 'None'. Mar 7, 2024
@AlexSkrypnyk
Copy link
Contributor

@joshua-salsadigital
this is great! Thank you for solving it here - the None Dropdown type should be doing what it says on the tin

however, for those users who has potentially used None to apply their own style, this would break their implementation.

We could have introduced Custom type which would be doing what None currently does. But we do not need to do this - any customisations are expected to be using custom twig templates. For this change - those consumers would have to revert their templates to the state before this change. We would need to add a release BC record about this.

@AlexSkrypnyk AlexSkrypnyk changed the title Issue #3422805 by joshua1234511: Fixed navigation menu when 'Dropdown type is set to 'None'. BC: Fixed navigation menu when 'Dropdown type is set to 'None'. Mar 7, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit b9e3979 into main Mar 7, 2024
5 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/3422805-navigation-dropdown-none branch March 7, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation component does not trim menu levels to the first level when none is selected
2 participants