Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#83 Updated storybook to show HTML source. #87

Merged
merged 2 commits into from
Jan 26, 2024
Merged

#83 Updated storybook to show HTML source. #87

merged 2 commits into from
Jan 26, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Jan 25, 2024 •
edited by AlexSkrypnyk
Loading

closes #83

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Added https://github.com/whitespace-se/storybook-addon-html
  2. Added patch to fix issue ValidationError: Invalid configuration object when using the addon in Storybook v7 whitespace-se/storybook-addon-html#102

Screenshots

Screenshot 2024-01-25 at 10 05 44 AM
Screenshot 2024-01-25 at 10 06 18 AM

@joshua-salsadigital joshua-salsadigital added the PR: Needs review Pull request needs a review from assigned developers label Jan 25, 2024
@joshua-salsadigital joshua-salsadigital self-assigned this Jan 25, 2024
@joshua-salsadigital joshua-salsadigital linked an issue Jan 25, 2024 that may be closed by this pull request
Show HTML source in Storybook #83
Closed
joshua-salsadigital
joshua-salsadigital commented Jan 25, 2024
View reviewed changes
package.json
@@ -27,7 +27,8 @@
"dist:dev": "export NODE_OPTIONS=--openssl-legacy-provider && webpack --config ./webpack/webpack.dev.js",
"test": "npm run test-storybook:ci",
"test-storybook": "test-storybook",
"test-storybook:ci": "concurrently --kill-others --success first --names \"SB,TEST\" --prefix-colors \"magenta,blue\" \"npx http-server storybook-static --port 6006 -a 127.0.0.1 --silent\" \"wait-on --timeout 10000 http://127.0.0.1:6006 && npm run test-storybook\""
"test-storybook:ci": "concurrently --kill-others --success first --names \"SB,TEST\" --prefix-colors \"magenta,blue\" \"npx http-server storybook-static --port 6006 -a 127.0.0.1 --silent\" \"wait-on --timeout 10000 http://127.0.0.1:6006 && npm run test-storybook\"",
"postinstall": "npx patch-package"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To Apply patch to fix
whitespace-se/storybook-addon-html#102

Screenshot 2024-01-25 at 10 03 29 AM

@github-actions GitHub Actions
Copy link

🚀 Deployed on https://65b1e7217cb033211dd5c1aa--civictheme-uikit.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 25, 2024 04:44 Inactive
@AlexSkrypnyk AlexSkrypnyk merged commit 92c0b2c into main Jan 26, 2024
3 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/83-html-source-storybook branch January 26, 2024 02:55
AlexSkrypnyk added a commit that referenced this pull request Mar 15, 2024
@AlexSkrypnyk
Revert "[#83] Updated storybook to show HTML source. (#87)"
8909fa9 
This reverts commit 92c0b2c.

# Conflicts:
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSkrypnyk AlexSkrypnyk AlexSkrypnyk approved these changes

Assignees

@joshua-salsadigital joshua-salsadigital

Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show HTML source in Storybook
2 participants
@joshua-salsadigital @AlexSkrypnyk