Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#79] Updated markup and prop for Promo component to be Contained or not. #84

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Jan 23, 2024

Checklist before requesting a review

closes #79

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Updated the markup to use the same approach as what Basic component uses - containment
  2. Added props to the Storybook story ( Contained & With background)

Screenshots

Screenshot 2024-01-23 at 8 37 20 AM
Screenshot 2024-01-23 at 8 37 26 AM

@joshua-salsadigital joshua-salsadigital self-assigned this Jan 23, 2024
@joshua-salsadigital joshua-salsadigital added the PR: Needs review Pull request needs a review from assigned developers label Jan 23, 2024
@AlexSkrypnyk AlexSkrypnyk changed the title #79 Updated markup and prop for Promo component to be Contained or not. [#79] Updated markup and prop for Promo component to be Contained or not. Jan 23, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 3bb8a79 into main Jan 23, 2024
3 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/79-promo-component-padding-issue branch January 23, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promo component does not have padding when used with a sidebar
2 participants