Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#392] Fixed inline css dependency issues. #431

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

alan-cole
Copy link
Collaborator

@alan-cole alan-cole commented Nov 26, 2024

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  • Fix subject card box-sizing.
  • Fix input box-sizing.
  • Fix navigation card box-sizing.
  • Fix campaign image box-sizing.
  • Fix iframe with background box-sizing.
  • Updated links in accordion to properly set light / dark.

I have not made any changes to slider as it is currently being worked on in #294

Screenshots

CIVIC-1937

- Fix subject card box-sizing.
- Fix input box-sizing.
- Fix navigation card box-sizing.
- Fix campaign image box-sizing.
- Fix iframe with background box-sizing.
@alan-cole alan-cole added the PR: Needs review Pull request needs a review from assigned developers label Nov 26, 2024
@alan-cole alan-cole self-assigned this Nov 26, 2024
Copy link

@github-actions github-actions bot temporarily deployed to pull request November 26, 2024 23:00 Inactive
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.75%. Comparing base (111194f) to head (348b5d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #431   +/-   ##
=======================================
  Coverage   13.75%   13.75%           
=======================================
  Files          27       27           
  Lines        1301     1301           
  Branches      308      308           
=======================================
  Hits          179      179           
  Misses        904      904           
  Partials      218      218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-cole Thanks I was just about to create an issue for this.

@febdao Your PR is superceded by this but thank you for fixing

@richardgaunt richardgaunt merged commit f64bac1 into main Dec 2, 2024
8 checks passed
@richardgaunt richardgaunt deleted the feature/392-inline-css-dependencies-fixes branch December 2, 2024 04:01
@alan-cole alan-cole mentioned this pull request Dec 2, 2024
7 tasks
@richardgaunt
Copy link
Collaborator

Fixes #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants