Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix and suffix variables to form elements. #413

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

civictheme/monorepo-drupal#1306

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Added fix to support Form element prefix & suffix.

Screenshots

@joshua-salsadigital joshua-salsadigital self-assigned this Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

@github-actions github-actions bot temporarily deployed to pull request October 24, 2024 04:00 Inactive
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.87%. Comparing base (85a6912) to head (7232aba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   13.87%   13.87%           
=======================================
  Files          27       27           
  Lines        1290     1290           
  Branches      307      307           
=======================================
  Hits          179      179           
  Misses        894      894           
  Partials      217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshua-salsadigital nice fix

@github-actions github-actions bot temporarily deployed to pull request October 24, 2024 06:13 Inactive
@richardgaunt richardgaunt changed the title Add opt-in for controlling what form elements are rendered via civictheme system Add prefix and suffix variables to form elements. Oct 24, 2024
@richardgaunt richardgaunt merged commit 23efae5 into main Oct 24, 2024
7 checks passed
@richardgaunt richardgaunt deleted the feature/form-elements-enhancement branch October 24, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants