-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#341] Added disable and single icon flags to text-icon. #403
Conversation
Applied settings to cards that were using non-standard styling of links with icons.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 13.87% 13.87%
=======================================
Files 27 27
Lines 1290 1290
Branches 307 307
=======================================
Hits 179 179
Misses 894 894
Partials 217 217 ☔ View full report in Codecov by Sentry. |
Fixes #341 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alan-cole Thanks this is a great solution
Checklist before requesting a review
as
[#123] Verb in past tense with a period at the end.
Changed
section about WHY something wasdone if this was a bespoke implementation.
and they have passed.
Changed
icon_group_disabled
andicon_single_only
flags to text-icon. This will allow for grouping to be disabled, and for external links to display in-place of icons.navigation-card
,next-step
,publication-card
andsubject-card
.Screenshots