Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#341] Added disable and single icon flags to text-icon. #403

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

alan-cole
Copy link
Collaborator

@alan-cole alan-cole commented Oct 4, 2024

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Added icon_group_disabled and icon_single_only flags to text-icon. This will allow for grouping to be disabled, and for external links to display in-place of icons.
  2. Applied the use of the new settings to cards that were using non-standard styling of links with icons. They include: navigation-card, next-step, publication-card and subject-card.

Screenshots

Screenshot 2024-10-04 at 4 27 14 pm
Screenshot 2024-10-04 at 4 26 59 pm
Screenshot 2024-10-04 at 4 26 49 pm
Screenshot 2024-10-04 at 4 26 41 pm
Screenshot 2024-10-04 at 4 26 26 pm

Applied settings to cards that were using non-standard styling of links with icons.
@alan-cole alan-cole requested a review from richardgaunt October 4, 2024 06:30
@alan-cole alan-cole added PR: Needs review Pull request needs a review from assigned developers PR: Do not review Do not review this pull request and removed PR: Needs review Pull request needs a review from assigned developers labels Oct 4, 2024
@alan-cole alan-cole added PR: Needs review Pull request needs a review from assigned developers and removed PR: Do not review Do not review this pull request labels Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

@github-actions github-actions bot temporarily deployed to pull request October 4, 2024 06:58 Inactive
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.87%. Comparing base (7315692) to head (3cd915e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   13.87%   13.87%           
=======================================
  Files          27       27           
  Lines        1290     1290           
  Branches      307      307           
=======================================
  Hits          179      179           
  Misses        894      894           
  Partials      217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardgaunt richardgaunt changed the title [CIVIC-1900] Added disable and single icon flags to text-icon. [341] Added disable and single icon flags to text-icon. Oct 7, 2024
@richardgaunt richardgaunt changed the title [341] Added disable and single icon flags to text-icon. [#341] Added disable and single icon flags to text-icon. Oct 7, 2024
@richardgaunt
Copy link
Collaborator

Fixes #341

Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-cole Thanks this is a great solution

@richardgaunt richardgaunt merged commit 077dc95 into main Oct 7, 2024
7 checks passed
@richardgaunt richardgaunt deleted the feature/CIVIC-1900-text-icon-fix branch October 7, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants