Fixed skip link having no target when Banner is not on the page. #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSkrypnyk
force-pushed
the
feature/fix-skip-link-target-when-no-banner
branch
from
1d9d3ae to
7221d58
Compare
AlexSkrypnyk
force-pushed
the
feature/fix-skip-link-target-when-no-banner
branch
from
7221d58 to
8637ffa
Compare
richardgaunt
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a tricky one
The Skip link skips to the
main-contentanchor. This anchor is set within the Banner to allow including of the page heading into what is considered to be a "whole page content".On the pages where the banner is not present (if a banner is replaced by another component, for example), the anchor is not rendered.
This PR adds the anchor on the page if the banner is not present.