Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#392] Fixed Content Link underline thickness. #393

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[#392] Fixed Content Link underline thickness. #393

merged 1 commit into from
Oct 1, 2024

Conversation

AlexSkrypnyk
Copy link
Contributor

@AlexSkrypnyk AlexSkrypnyk commented Sep 30, 2024 •
edited
Loading

In Figma, the underline is 1px, but in UIKit it is erroneously 2px.

DrevOps_-_CivicTheme__Design_System_v1_8_0

Before:

Atoms___Content_Link_-_Content_Link_⋅_Storybook

After:
Atoms___Content_Link_-_Content_Link_⋅_Storybook

@richardgaunt richardgaunt requested a review from alan-cole October 1, 2024 10:17
@richardgaunt richardgaunt mentioned this pull request Oct 1, 2024
Open
@richardgaunt richardgaunt added the PR: Needs review Pull request needs a review from assigned developers label Oct 1, 2024
@richardgaunt richardgaunt self-requested a review October 1, 2024 10:33
richardgaunt
richardgaunt approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@richardgaunt richardgaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and looks good to me.

@richardgaunt richardgaunt changed the title Fixed Content Link underline thickness. #392 Fixed Content Link underline thickness. Oct 1, 2024
@richardgaunt richardgaunt changed the title #392 Fixed Content Link underline thickness. [#392] Fixed Content Link underline thickness. Oct 1, 2024
@richardgaunt richardgaunt merged commit 0f6ca1a into civictheme:main Oct 1, 2024
5 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the patch-1 branch October 2, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardgaunt richardgaunt richardgaunt approved these changes

@alan-cole alan-cole Awaiting requested review from alan-cole

Assignees

@AlexSkrypnyk AlexSkrypnyk

Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexSkrypnyk @richardgaunt