[#389] Removed aria-label from button with 'is_new_window'.

[alan-cole]

#389

Checklist before requesting a review

• I have formatted the subject to include the issue number
  as [#123] Verb in past tense with a period at the end.
• I have provided information in the Changed section about WHY something was
  done if this was a bespoke implementation.
• I have performed a self-review of my code.
• I have commented on my code, particularly in hard-to-understand areas.
• I have added tests that prove my fix is effective or that my feature works.
• I have run new and existing relevant tests locally with my changes,
  and they have passed.
• I have provided screenshots, where applicable.

Changed

1. The aria-label in this case would override whatever text was present within the button, meaning buttons lose context if used with a screen reader.

Screenshots

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.87%. Comparing base (343d1ff) to head (15b2d31).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   13.87%   13.87%           
=======================================
  Files          27       27           
  Lines        1290     1290           
  Branches      307      307           
=======================================
  Hits          179      179           
  Misses        894      894           
  Partials      217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

🚀 Deployed on https://66f39424ac1c22a7f3222715--civictheme-uikit.netlify.app

[richardgaunt]

Thanks @alan-cole - and thanks for explaining the fix.