Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#308] Fixed Layout masonry is not applied when nested Layout is used. #310

Conversation

AlexSkrypnyk
Copy link
Contributor

@AlexSkrypnyk AlexSkrypnyk commented Jun 30, 2024

closes #308

This PR changes 2 things:

  1. We are no longer observing the grid's items - we are observing grid's items' children to track the change of their heigh.
  2. The selection of the grid elements is now scoped to the immediate children to allow binding to nested layouts correctly.
22.mov

@AlexSkrypnyk AlexSkrypnyk changed the title [#308] Fixed Layout masonry is not applied when nested Layout is used. @AlexSkrypnyk [#308] Fixed Layout masonry is not applied when nested Layout is used. Jun 30, 2024
@AlexSkrypnyk AlexSkrypnyk force-pushed the feature/308-fixed-layout-masonry-is-not-applied-when-nested-Layout-is-used branch from 3737d14 to d26d7ca Compare June 30, 2024 02:21
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 13.92%. Comparing base (9617c4a) to head (d26d7ca).

Files Patch % Lines
components/00-base/layout/layout.js 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   13.97%   13.92%   -0.05%     
==========================================
  Files          27       27              
  Lines        1281     1285       +4     
  Branches      306      306              
==========================================
  Hits          179      179              
- Misses        886      890       +4     
  Partials      216      216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk merged commit a0fd4f3 into main Jun 30, 2024
2 of 6 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/308-fixed-layout-masonry-is-not-applied-when-nested-Layout-is-used branch June 30, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout masonry is not applied when nested Layout is used
1 participant