-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#147] Updated Chip component color mapping. #176
Conversation
components/01-atoms/chip/chip.scss
Outdated
|
||
&.ct-theme-light { | ||
&.active { | ||
&:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to the map above as active-hover
and update ct-button-type()
mixin to support active-hover
type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexSkrypnyk I have updated the Pr as per your suggestions.
Updated styles are for selected and selected hover. Storybook have knob that allow you to make the chip selected. I am not sure active state applied for chip. |
Checklist before requesting a review
as
[#123] Verb in past tense with a period at the end.
Changed
section about WHY something wasdone if this was a bespoke implementation.
and they have passed.
#147
Changed
Screenshots
Hover:

Selected:

Selected:hover:

Dark

Hover:

Selected:

Selected:hover:
