[#78] Fixed Single and Group filter announcing changes to content and a "down" key trigger for collapsible. #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o right, top to bottom (e.g. first row left to right and then second row left to right).
joshua-salsadigital
added
the
State: Needs more work
AlexSkrypnyk
added
PR: Requires more work
joshua-salsadigital
added
PR: Needs review
AlexSkrypnyk
suggested changes
Mar 26, 2024
| t.el.setAttribute('aria-live', 'polite'); | ||
| }; | ||
|
|
||
| // Find group Filter components and initialize |
| * Update the instance. | ||
| */ | ||
| CivicThemeGroupFilterComponent.prototype.update = function () { | ||
| const t = this; |
|
|
||
| this.el = el; | ||
|
|
||
| this.el.addEventListener('ct.group-filter.update', () => { |
There was a problem hiding this comment.
this.el.addEventListener('ct.group-filter.update', this.update.bind(this, true)
| this.update(true); | ||
| }); | ||
|
|
||
| // Function to trigger custom event |
There was a problem hiding this comment.
please remove this and other comments like this - they are not describing anything useful
| }; | ||
|
|
||
| // Function to bind event listeners | ||
| const bindEventListeners = function () { |
There was a problem hiding this comment.
please simplify this by not using the bindEventListeners
this.el.querySelectorAll('input, textarea, select, [type="checkbox"], [type="radio"]').forEach((input) => {
input.addEventListener('change', function(){
// Find parent.
const parent = this.parent..
parent.dispatchEvent(new CustomEvent('ct.group-filter.update'));
});
});
| * @file | ||
| * Single Filter component. | ||
| */ | ||
| function CivicThemeSingleFilterComponent(el) { |
There was a problem hiding this comment.
this needs to have the same updates as above
AlexSkrypnyk
added
PR: Requires more work
joshua-salsadigital
added
PR: Needs review
AlexSkrypnyk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78
Checklist before requesting a review
as
[#123] Verb in past tense with a period at the end.Changedsection about WHY something wasdone if this was a bespoke implementation.
and they have passed.
Changed
Screenshots