Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#69] Fixed TAB-out from the mobile menu is not working. #112

Merged
merged 2 commits into from
Apr 10, 2024
Merged

[#69] Fixed TAB-out from the mobile menu is not working. #112

merged 2 commits into from
Apr 10, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Mar 14, 2024 •
edited
Loading

Closes #69

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Added Tabbing in Flyout component to “cycle” back to the first component instead of going to the page behind it.

Screenshots

https://nimb.ws/sF4IT0g

@joshua-salsadigital joshua-salsadigital added the PR: Needs review Pull request needs a review from assigned developers label Mar 14, 2024
@joshua-salsadigital joshua-salsadigital self-assigned this Mar 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

🚀 Deployed on https://660c674b79c7382631ad79df--civictheme-uikit.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 14, 2024 12:08 Inactive
This was referenced Mar 14, 2024
Closed
Closed
@joshua-salsadigital
Copy link
Collaborator Author

Test PR: https://nginx-php.pr-1232.civictheme-monorepo-drupal.lagoon.salsa.hosting/

@AlexSkrypnyk AlexSkrypnyk changed the title [69] Fixed TAB-out from the mobile menu is not working. [#69] Fixed TAB-out from the mobile menu is not working. Mar 15, 2024
@AlexSkrypnyk AlexSkrypnyk added this to the 1.8 milestone Mar 15, 2024
@github-actions github-actions bot temporarily deployed to pull request April 2, 2024 20:15 Inactive
@AlexSkrypnyk AlexSkrypnyk merged commit 5377f7e into main Apr 10, 2024
4 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/69-tab-out-cycle branch April 10, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSkrypnyk AlexSkrypnyk AlexSkrypnyk left review comments

Assignees

@joshua-salsadigital joshua-salsadigital

Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
UI Kit
Status: Done
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

TAB-out from the mobile menu is not working
2 participants
@joshua-salsadigital @AlexSkrypnyk