Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3512157] Added better access check on local task links. #1357

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

richardgaunt
Copy link
Collaborator

Checklist before requesting a review

  • I have formatted the subject to include ticket number as Issue #123456 by drupal_org_username: Issue title
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Added check for boolean access value rather than just expecting an AccessInterface object
  2. Added better check of link array properties in local tasks preprocessing.

@richardgaunt richardgaunt merged commit 519c992 into develop Mar 11, 2025
11 of 13 checks passed
@richardgaunt richardgaunt deleted the feature/added-better-check-local-tasks branch March 11, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant