Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3505673 by joshua1234511, richardgaunt, jezrsh, fionamorrison23: ArgumentCountError when using content provisioning functiong #1332

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Feb 12, 2025

https://www.drupal.org/project/civictheme/issues/3505673

Checklist before requesting a review

  • I have formatted the subject to include ticket number as Issue #123456 by drupal_org_username: Issue title
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Added a fix for D11 - ArgumentCountError when using content provisioning functiong

Screenshots

@joshua-salsadigital joshua-salsadigital added the State: DO NOT MERGE Do not merge this pull request label Feb 12, 2025
@joshua-salsadigital joshua-salsadigital self-assigned this Feb 12, 2025
@joshua-salsadigital
Copy link
Collaborator Author

@richardgaunt

Updated the monorepo to Drupal 11 Loaclly

Encountered incompatibility with the following modules:
CivicTheme Admin
CivicTheme Default Content
CivicTheme Default Demo Content
CivicTheme Development
CivicTheme Generated Content
Styleguide module

GovCMS/govcms locked certain dependencies.
Bypassed by manually removing the modules from composer.

Root Cause:
Drupal 11 requires ThemeExtensionList in the constructor.

Fix:
Added the required ThemeExtensionList to resolve the issue.

As a temporary solution Patch https://www.drupal.org/project/civictheme/issues/3505673#comment-15984361

Screenshot 2025-02-12 at 5 37 08 PM
Screenshot 2025-02-12 at 5 37 15 PM
Screenshot 2025-02-12 at 5 37 34 PM

@joshua-salsadigital joshua-salsadigital added State: Needs review Pull requests needs a review from assigned developers and removed State: DO NOT MERGE Do not merge this pull request labels Feb 12, 2025
@richardgaunt richardgaunt merged commit 4e87a5e into develop Feb 13, 2025
3 checks passed
@richardgaunt richardgaunt deleted the feature/3505673-d11-compabilty branch February 13, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Needs review Pull requests needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants