Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3415685 by joshua1234511: Add a hidden region for entity references to civictheme.info.yml #1229

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Mar 13, 2024

https://www.drupal.org/project/civictheme/issues/3415685

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [CS-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Added hidden region at the bottom of the theme with a UI Kit class 'ct-visually-hidden'.
  2. Updated stater-kit to include the new region.

Screenshots

Screenshot 2024-03-13 at 8 40 52 PM

@joshua-salsadigital joshua-salsadigital added the State: Needs review Pull requests needs a review from assigned developers label Mar 13, 2024
@joshua-salsadigital joshua-salsadigital self-assigned this Mar 13, 2024
@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (squash) March 14, 2024 00:32
@AlexSkrypnyk AlexSkrypnyk added State: Ready to be merged Pull request is ready to be merged (assigned after testing is complete) and removed State: Needs review Pull requests needs a review from assigned developers labels Mar 14, 2024
@AlexSkrypnyk AlexSkrypnyk merged commit 8f4a2d7 into develop Mar 14, 2024
11 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/3415685-hidden-region branch March 14, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Ready to be merged Pull request is ready to be merged (assigned after testing is complete)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants