Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3415742 by joshua1234511: Fixed Nodes within an Automated list should not reference itself. #1219

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

joshua-salsadigital
Copy link
Collaborator

@joshua-salsadigital joshua-salsadigital commented Mar 7, 2024

https://www.drupal.org/project/civictheme/issues/3415742

Checklist before requesting a review

  • I have formatted the subject to include ticket number as [CS-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

  1. Updated the view config to exclude the current node.
  2. Updated tests to check for the current node's absence.

Screenshots

Screenshot 2024-03-07 at 3 46 06 PM
Screenshot 2024-03-07 at 4 18 14 PM

@joshua-salsadigital joshua-salsadigital added the State: Needs review Pull requests needs a review from assigned developers label Mar 7, 2024
@joshua-salsadigital joshua-salsadigital self-assigned this Mar 7, 2024
@AlexSkrypnyk AlexSkrypnyk enabled auto-merge (squash) March 7, 2024 22:54
@AlexSkrypnyk AlexSkrypnyk disabled auto-merge March 7, 2024 23:26
@AlexSkrypnyk AlexSkrypnyk merged commit 9804856 into develop Mar 7, 2024
12 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/3415742-automated-list-fix branch March 7, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Needs review Pull requests needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants