Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure light mode is forced in backoffice on Drupal 7 builds #901

Closed
wants to merge 2 commits into from
Closed

Ensure light mode is forced in backoffice on Drupal 7 builds #901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ed7108
Ensure light mode is forced in backoffice on Drupal 7 builds
seamuslee001 Dec 11, 2024
95aef04
Also apply setting to WordPress installs as well
seamuslee001 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/civibuild.lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,9 @@ function civicrm_enable_riverlea_theme() {
if civicrm_check_ver '>' 5.80.alpha1 ; then
cv en --ignore-missing riverlea
cv vset theme_backend=minetta
if [[ "$CIVI_UF" == "Drupal" ] || [ "$CIVI_UF" == "WordPress" ]]; then
Copy link
Member

@kcristiano kcristiano Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to change to this:

diff --git a/src/civibuild.lib.sh b/src/civibuild.lib.sh
index 8ccd4fb..e44a931 100644
--- a/src/civibuild.lib.sh
+++ b/src/civibuild.lib.sh
@@ -645,8 +645,11 @@ function civicrm_enable_riverlea_theme() {
   if civicrm_check_ver '>' 5.80.alpha1 ; then
     cv en --ignore-missing riverlea
     cv vset theme_backend=minetta
-    if [[ "$CIVI_UF" == "Drupal" ] || [ "$CIVI_UF" == "WordPress" ]]; then
+    if [ "$CIVI_UF" == "Drupal" ] ; then
+       cv vset riverlea_dark_mode_backend=light
+    elif [ "$CIVI_UF" == "WordPress" ] ;  then
       cv vset riverlea_dark_mode_backend=light
+      cv vset riverlea_dark_mode_frontend=light
     fi
   fi
 }

I was getting errors using the || syntax

updated to do front end on WP

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this setup - the back end setting is updated properly

should we also set front end here?

cv vset riverlea_dark_mode_backend=light
fi
fi
}

Expand Down