Tart/Vetu: log *exec.Cmd standard output/error streams to OpenTelemetry #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkorotkov
reviewed
Jan 15, 2025
| errChan chan error | ||
| ident string | ||
| env map[string]string | ||
| backgroundCtxWithSpan context.Context |
There was a problem hiding this comment.
Can we just in place use something like
trace.ContextWithSpan(context.Background(), trace.SpanFromContext(vm.runningVMCtx))for all Cmd invocations? Why storing it?
There was a problem hiding this comment.
Why storing it?
Because (vm *VM) Close() needs it.
There was a problem hiding this comment.
It can do it in in place:
ctx := trace.ContextWithSpan(context.Background(), trace.SpanFromContext(vm.runningVMCtx))
fkorotkov
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this:
Tried to use
log/slog, but unfortunately its OpenTelemetry bridge lacks context propagation andlog/sloghas no handy adapters likego.uber.org/zap/zapio.