Dynamically configurable standby instance #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edigaryev
reviewed
Jan 13, 2025
internal/worker/worker.go
Outdated
| @@ -303,8 +304,9 @@ func (worker *Worker) tryCreateStandby(ctx context.Context) { | |||
|
|
|||
| worker.logger.Debugf("warming-up the standby instance") | |||
|
|
|||
| warmUpTimeout := time.Duration(worker.standbyParameters.Warmup.TimeoutSeconds) * time.Second | |||
There was a problem hiding this comment.
This seems to cause NPE in tests: https://cirrus-ci.com/task/5965693838950400?logs=test#L3291-L3303
There was a problem hiding this comment.
Another point is that since the worker.standbyParameters and its inner messages are now nil-able, and the standby parameters can be set from the backend, it would be nice if we can check for nil here in a more defensive manner.
edigaryev
reviewed
Jan 13, 2025
edigaryev
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved standby configuration in proto and added configuration to gRPC polling methods.