Option for delayed pre-pull #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to make rollouts during peak hours without downtimes. Once we have `.system_info` it will be easier to see which image is used for a run.
edigaryev
reviewed
Jan 8, 2025
| lazyPull := false | ||
|
|
||
| if worker.tartPrePull != nil && worker.tartPrePull.NeedsPrePull() { | ||
| // Pre-pull the configured Tart VM images first |
There was a problem hiding this comment.
Let's say we have configured ghcr.io/cirruslabs/macos-runner:sonoma for the pre-pull.
A new version of this image gets released, and we skip this code block because we've already performed a check recently, but before the image was available.
As a result, lazyPull won't be set to true, and Warmup() below will pull the new image. This will likely happen on all the workers, which corresponds to the current behavior 🤔
There was a problem hiding this comment.
My bad! You are absolutely correct. What about this logic in 84f7462?
edigaryev
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to make rollouts during peak hours without downtimes.
Once we have
.system_infoit will be easier to see which image is used for a run.