Persistent Worker: support warm-up script (with optional timeout) and report more metrics #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edigaryev
changed the title
warmup: {script: "", timeout: ""} and report more metrics
edigaryev
changed the title
warmup: {script: "", timeout: ""} and report more metrics
fkorotkov
reviewed
Nov 18, 2024
| return nil | ||
| } | ||
|
|
||
| logger.Infof("running warm-up script...") |
There was a problem hiding this comment.
Can we also add a span or a metric here for how long it takes to run the script?
There was a problem hiding this comment.
Added in 2b34e78.
fkorotkov
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #811, resolves #810.
Examples: