Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA cache: report failures to Sentry #790

Merged
merged 1 commit into from
Sep 27, 2024
Merged

GHA cache: report failures to Sentry #790

merged 1 commit into from
Sep 27, 2024

Conversation

edigaryev
Copy link
Contributor

@edigaryev edigaryev commented Sep 23, 2024

And also move towards structured logging a bit more by parametrizing the failure attributes.

Looks like this (note the url, which github.com/getsentry/sentry-go/http package provides:

Screenshot 2024-09-23 at 21 01 31

And this:

Screenshot 2024-09-23 at 21 01 15

@edigaryev edigaryev requested a review from fkorotkov September 23, 2024 17:00
Copy link
Contributor

@fkorotkov fkorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to make sure we pass SENTRY_DNS to the agent and make sure the agent is not leaking it to script instructions.

@edigaryev
Copy link
Contributor Author

Let's merge this as is for now, I'll follow-up with either a (1) SENTRY_DSN passthrough or (2) a way to collect these logs in Persistent Worker and tag them with a task ID and other tags.

@edigaryev edigaryev merged commit 60e7903 into master Sep 27, 2024
10 checks passed
@edigaryev edigaryev deleted the gha-cache-sentry branch September 27, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants