First refactoring for better readability #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LegenJCdary
force-pushed
the
first_refactor
branch
from
1a715cc to
3e923df
Compare
cinek810
reviewed
Feb 10, 2022
| @@ -20,20 +20,11 @@ | |||
| LOG_NAME_FRMT = "ansible-deploy_execution_{}.log" | |||
|
|
|||
|
|
|||
| def get_sub_command(command): | |||
There was a problem hiding this comment.
I'm not sure.. this removes the guarantee that subcommand is one of the fixed strings...
cinek810
reviewed
Feb 10, 2022
| @@ -502,13 +502,13 @@ def main(): | |||
| sys.exit(2) | |||
| options = parse_options(sys.argv[1:]) | |||
|
|
|||
| log_dir = None | |||
There was a problem hiding this comment.
maybe we'll add a configuration or option for log_dir one day to allow file logging for other commands?
cinek810
reviewed
Feb 10, 2022
| @@ -504,11 +504,9 @@ def main(): | |||
| workdir = None | |||
|
|
|||
| logger = set_logging(workdir, start_ts, options) | |||
|
|
|||
There was a problem hiding this comment.
I don't like commits just removing/adding blank lines it just makes git blame more dificult to read
cinek810
reviewed
Feb 10, 2022
| @@ -520,7 +518,7 @@ def main(): | |||
| else: | |||
| lockdir = os.path.join(conf["global_paths"]["work_dir"], "locks") | |||
| inv_file = get_inventory_file(config, options) | |||
| lockpath = os.path.join(lockdir, inv_file.replace(os.sep, "_")) | |||
There was a problem hiding this comment.
so we left the basename? basename is a bug
cinek810
reviewed
Feb 10, 2022
| import yaml | ||
| from cerberus import Validator | ||
| #TODO: Add an option to explicitly enable syslog logging | ||
| #from logging import handlers as log_han | ||
|
|
||
|
|
There was a problem hiding this comment.
that's good one , separate comit for blank lines cleanup
cinek810
approved these changes
Feb 10, 2022
LegenJCdary
force-pushed
the
first_refactor
branch
from
48aa6d9 to
b49dff1
Compare
Replace usage of base_dir with global conf workdir
LegenJCdary
force-pushed
the
first_refactor
branch
from
b49dff1 to
28c3e0c
Compare
LegenJCdary
force-pushed
the
first_refactor
branch
from
28c3e0c to
e5c0a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.