chore: added verifier tests #3433
Open
+114
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshishNaware
force-pushed
the
go_verifier_test
branch
from
322a008 to
c0669ba
Compare
olsajiri
reviewed
Feb 25, 2025
| /^;/ { if (in_func) { print " " $0; in_func=0; } } | ||
| /^verification time/ { verify_lines=3 } | ||
| /^/ { if (verify_lines) { verify_lines -= 1; print " " $0 } }' < "$OUT" | ||
| rm "$OUT" |
There was a problem hiding this comment.
not sure we could easily do this output, nor I'm sure we really need that.. I just don't see it in new code, so would be great to have some comment about that (like in changelog)
There was a problem hiding this comment.
added comment in changelog
There was a problem hiding this comment.
added comment in changelog
@AshishNaware aah I meant commit changelog (not PR) so we have the info in the git log, thanks
AshishNaware
force-pushed
the
go_verifier_test
branch
2 times, most recently
from
9c77db3 to
eba1d72
Compare
'make verify' target now runs go tests to test object files instead of running verifier script. * invoke make verify to run the tests. * run tests in debug mode: DEBUG=1 make verify * run tests on specific directory with .o files: TETRAGONDIR=<path_to_dir> make verify * Note: unlike old script, these tests do not provide these metrics: verification time, stack depth, processed insns, max_state_per_insn, total_states, peak_states,mark_read Signed-off-by: Ashish Naware <ashishnaware3@gmail.com>
AshishNaware
force-pushed
the
go_verifier_test
branch
from
eba1d72 to
8f78a54
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I am not able to add any labels to this PR |
olsajiri
reviewed
Feb 28, 2025
| @@ -277,7 +278,7 @@ bpf-test: | |||
|
|
|||
| .PHONY: verify | |||
| verify: tetragon-bpf ## Verify BPF programs. | |||
| sudo contrib/verify/verify.sh bpf/objs | |||
| sudo DEBUG=${DEBUG} TETRAGONDIR=${TETRAGONDIR} $(shell which go) test contrib/verify/verify_test.go -v | |||
| @@ -19,6 +19,7 @@ GO_TEST_TIMEOUT ?= 20m | |||
| E2E_TEST_TIMEOUT ?= 20m | |||
| BUILD_PKG_DIR ?= $(shell pwd)/build/$(TARGET_ARCH) | |||
| VERSION ?= $(shell git describe --tags --always --exclude '*/*') | |||
| TETRAGONDIR ?= $(CURDIR)/bpf/objs | |||
There was a problem hiding this comment.
no need for TETRAGONDIR variable, please use $(CURDIR)/bpf/objs directly
| require.NoError(t, err, "failed to load resources into the kernel") | ||
|
|
||
| collection.Close() | ||
|
|
| collection.Close() | ||
|
|
||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#229 replace verifier.sh with a go verifier test that uses cilium/ebpf
Description
This change adds go tests using cilium/ebpf library as an alternative to verifier script. The test closely mimics all the actions of verifier.sh.
-dflag produces more verbose output than the earlier script.Changelog
release-note
make verifytarget now invokes go tests to test object files instead of running verifier script. Below is the sample usagesuccessful execution:
Test fails for the invalid file with error message:
use debug flag to get verbose output
To provide specific object directory
Note:
unlike old script, this test does not provide below metrics
verification time,
stack depth,
processed insns,
max_states_per_insn,
total_states,
peak_states,
mark_read