Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link: minimal windows support #1718

Merged
merged 3 commits into from
Mar 19, 2025
Merged

link: minimal windows support #1718

merged 3 commits into from
Mar 19, 2025

Conversation

lmb
Copy link
Collaborator

@lmb lmb commented Mar 10, 2025

link: split out platform specific code

Move platform specific code into separate files. No other changes intended.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

link: streamline test helpers

Change test helpers so that they are easier to implement on other platforms.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

link: minimal windows support

We retain the Link interface and the RawLink type, but all other link types
are not available on Windows. There is a possibility that we can extend the
XDP link to Windows, but that will have to come later.

There is no support to retrieve link information or to pass additional 
context to the link create call.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

@lmb lmb force-pushed the windows-link branch 3 times, most recently from 611f8ed to 394f57c Compare March 17, 2025 11:37
@lmb lmb marked this pull request as ready for review March 17, 2025 12:29
@lmb lmb requested review from mmat11 and a team as code owners March 17, 2025 12:29
@lmb lmb force-pushed the windows-link branch 2 times, most recently from 24bd41b to 1698753 Compare March 17, 2025 15:01
lmb added 2 commits March 17, 2025 14:59
Move platform specific code into separate files. No other changes
intended.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Change test helpers so that they are easier to implement on
other platforms.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
We retain the Link interface and the RawLink type, but all other link
types are not available on Windows. There is a possibility that we can
extend the XDP link to Windows, but that will have to come later.

There is no support to retrieve link information or to pass additional
context to the link create call.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb merged commit 1445440 into cilium:main Mar 19, 2025
17 checks passed
@lmb lmb deleted the windows-link branch March 19, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants