Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder cmd source to better conform to project layout advice #38

Merged
merged 2 commits into from
Nov 1, 2020

Conversation

aaronsky
Copy link
Member

@aaronsky aaronsky commented Nov 1, 2020

Description

Let's see if this makes the source any easier to reason about.

Type of Change

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been Tested?

  • Ran goreleaser locally on PC, Mac, and in a Mint VM

@codecov-io
Copy link

codecov-io commented Nov 1, 2020

Codecov Report

Merging #38 into main will increase coverage by 0.51%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   64.14%   64.66%   +0.51%     
==========================================
  Files          36       35       -1     
  Lines        2365     2346      -19     
==========================================
  Hits         1517     1517              
+ Misses        760      741      -19     
  Partials       88       88              
Impacted Files Coverage Δ
cmd/cider/main.go 61.53% <ø> (ø)
pkg/cmd/check.go 0.00% <ø> (ø)
pkg/cmd/completions.go 0.00% <ø> (ø)
pkg/cmd/config.go 100.00% <ø> (ø)
pkg/cmd/error.go 100.00% <ø> (ø)
pkg/cmd/init.go 53.29% <ø> (ø)
pkg/cmd/release.go 0.00% <ø> (ø)
pkg/cmd/root.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44eed0...a0e12b6. Read the comment docs.

@aaronsky aaronsky merged commit 2faf809 into main Nov 1, 2020
@aaronsky aaronsky deleted the asky_reorder_cmd_source branch November 1, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants