-
Notifications
You must be signed in to change notification settings - Fork 39
Support JSON response body #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is
|
That's my first experience in Go so it is probably not the best solution, but still it works :) |
Finally I had some time to look into it. If the HTTP response can be parsed as a json object then it will be returned as a json structure. Here I plan to use the mode parameter is in your PR. If the HTTP response cannot be parsed as a structure then the response as returned unchanged as a string. What do you think? |
Thought about it, but this would make it impossible to use the same index name for both json and non-json responses because the |
Valid point, will rethink it again. |
Any news here? |
I was busy with some activities in the last weeks. I will look into it the next days but most likely the PR will be merged unchanged or only smaller internal changes and keeping the approach using a dedicated field. |
I merged your PR unchanged and a release 1.1.0 is available. Thanks very much for your contribution again. |
👍 |
This implements issue #2
Store JSON response body in jsonBody field; Transform dot notation to nested JSON