Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work on windows due to use of colon in filenames #72

Closed
zidjian257 opened this issue Jun 29, 2016 · 2 comments · Fixed by #73
Closed

does not work on windows due to use of colon in filenames #72

zidjian257 opened this issue Jun 29, 2016 · 2 comments · Fixed by #73

Comments

@zidjian257
Copy link

Just had a hard time to get this addon running on windows.
I know not many use windows as their operating system in the ember community, but unfortunatelly I have to, due to my employer :-(

Running on windows the addon does not render handlebars snippets for freestyle-usage as well as notes do not work.

As I found out this is because the freestyle-usage-snippet-finder and the freestyle-usage component use colons : to seperate the slug from notes and usage.
This is then used as temporary filenames on build time, which windows does not support.

To get it running I would suggest to use an underscore instead of the colon. What do you think?

@zidjian257
Copy link
Author

Argh, all Tests Failed. As this broke backwords compability. I will take a Look to find a better aproach tomorrow

zidjian257 pushed a commit to zidjian257/ember-freestyle that referenced this issue Jun 30, 2016
zidjian257 pushed a commit to zidjian257/ember-freestyle that referenced this issue Jun 30, 2016
zidjian257 pushed a commit to zidjian257/ember-freestyle that referenced this issue Jun 30, 2016
@zidjian257
Copy link
Author

OK, looks good to me like this.
It now uses underscores for filenaming but, still allows using colons in the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant