Skip to content

Incompatible with Numpy 1.24 #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
js-truework opened this issue Dec 19, 2022 · 7 comments
Open

Incompatible with Numpy 1.24 #283

js-truework opened this issue Dec 19, 2022 · 7 comments

Comments

@js-truework
Copy link

Numpy 1.24 was released recently, and it looks like there is (at least one) deprecation that abydos relies on. Relevant stack trace snippet below.

Opening this for tracking purposes.

  File "/.venv/lib/python3.10/site-packages/abydos/distance/_aline.py", line 25, in <module>
    from numpy import float as np_float
ImportError: cannot import name 'float' from 'numpy' (/.venv/lib/python3.10/site-packages/numpy/__init__.py)

A fast solution to this would be to update the numpy version constraints in pyproject.toml/setup.py (this project has both and I don't know which is used for build) to also include <1.24.

@mgorny
Copy link

mgorny commented Dec 22, 2022

Given last commit in Jan 2021, I wouldn't get my hopes up.

@chrislit
Copy link
Owner

chrislit commented Dec 22, 2022 via email

@mgorny
Copy link

mgorny commented Dec 22, 2022

Thanks for letting me know. In that case, I'll give it a try and see if I can make a PR to fix it.

@mgorny
Copy link

mgorny commented Dec 22, 2022

Hmm, actually, it looks like master is good already, just needs a new release.

@joaodperes
Copy link

Hi, are there any updates on this issue? I've installed abydos v0.5.0 (via PyPI) and v0.6.0 (via GIT) but i'm getting the above error with both versions.

@bwo
Copy link

bwo commented Sep 27, 2023

it's been a year, if the problem is fixed on master can a new release be cut?

@ma7dev
Copy link

ma7dev commented Feb 5, 2024

@joaodperes @bwo the issue seems to be fixed in 0.6.0b version which was merged to master. Use git to install the package or if you use poetry, use poetry add git+https://github.com/chrislit/abydos.git. It worked from my end :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants