Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow enable/disable option for icons #9

Closed
wants to merge 1 commit into from
Closed

feat: allow enable/disable option for icons #9

wants to merge 1 commit into from

Conversation

tdback
Copy link

@tdback tdback commented Oct 25, 2024

Checklist

  • Used only camelCase variable names.
  • If functionality is added or modified, also made respective changes to the
    README.md (the .txt file is auto-generated and does not need to be modified).

This feature allows someone to enable or disable the use of icons in their configuration without having to manually set the value of each hint to "". This is helpful when someone is using an un-patched font, or one that doesn't contain icons.

@chrisgrieser
Copy link
Owner

Thanks for the PR, but why not just set the icons to "" if you want to disable them?

@tdback
Copy link
Author

tdback commented Oct 25, 2024

I initially found myself looking for an option to enable/disable, as I feel it's quite common across other plugins. Given there's only a few options I would have to change to remove icons it's not too much of a hassle if it doesn't get merged. Just thought I'd add it in!

@chrisgrieser
Copy link
Owner

I see. I think for the sake of keeping the plugin as minimal as possible, I think "" should suffice to disable them.

Other plugins may have a separate toggle, but that's probably cause they simply have a lot of icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants