Skip to content

Commit

Permalink
Use install instead of cp for install purposes.
Browse files Browse the repository at this point in the history
The install utility will set the proper permissions for the file
at hand while cp just sets the permissions at the destination
it gets from the original file - which might be totally wrong
depending on the users' umask.

Signed-off-by: Henner Zeller <h.zeller@acm.org>
  • Loading branch information
hzeller committed Jan 16, 2021
1 parent e886d8c commit c613a35
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions Makefile_plugin.common
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ $(NAME).so: $(OBJS)
$(CXX) $(CXXFLAGS) $(LDFLAGS) -shared -o $@ $^ $(LDLIBS)

install_plugin: $(NAME).so
mkdir -p $(PLUGINS_DIR)
cp $< $(PLUGINS_DIR)/$<
install -D $< $(PLUGINS_DIR)/$<

test:
$(MAKE) -C tests all
Expand Down
3 changes: 1 addition & 2 deletions xdc-plugin/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ include ../Makefile_plugin.common
VERILOG_MODULES = BANK.v

install_modules: $(VERILOG_MODULES)
mkdir -p $(PLUGINS_DIR)/fasm_extra_modules/
cp $< $(PLUGINS_DIR)/fasm_extra_modules/$<
install -D $< $(PLUGINS_DIR)/fasm_extra_modules/$<

install: install_modules

0 comments on commit c613a35

Please sign in to comment.