Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prci] Add a pair of diplomatic reset synchronizers #2666

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

davidbiancolin
Copy link
Contributor

Type of change: other enhancement

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes

  • [prci] Add a pair of diplomatic reset synchronizers

Some other thoughts:

  • Here I don't bother exposing any of the underlying parameters of ResetCatchAndSync; if that's desired i can add requested ones.
  • ResetWrangler could be made more diplomatic in spirit by removing its direct instantiation of ResetCatchAndSync.

@mwachs5 mwachs5 requested review from hcook and rmac-sifive October 13, 2020 21:55
@colinschmidt
Copy link
Contributor

I feel like the sync parameters for AsyncQueue and ResetCatchAndSync should be coupled by default in my opinion, and having that default settable by some parameter would be all I cared about in terms of params.
This is not a very straightforward change or one thats related to this PR necessarily but it's my 2 cents.

@hcook
Copy link
Member

hcook commented Oct 15, 2020

@colinschmidt I agree that there is some potential value to coupling them, but I wonder what the scope of such coupling is... is it really global? Does it depend how relatively asynchronous the two domains in question are? (I confess I don't personally know much about the criteria that go into successfully choosing this parameter.)

@davidbiancolin davidbiancolin merged commit a002166 into master Oct 16, 2020
@davidbiancolin davidbiancolin deleted the diplo-reset-sync branch October 16, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants