Verification Failure Test with SignDecode_h #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ekarabu
commented
Mar 3, 2025
•
ekarabu
commented
- This test case is designed to validate an expected failure scenario in the MLDSA signature verification routine.
- Specifically, it targets an error condition related to the signature decode hint (singdecode_h).
There was a problem hiding this comment.
PR Overview
This PR adds a new YAML test configuration file for the "ML_DSA_randomized_h_decode_fail_test" verification failure.
- Introduces a YAML file to configure test parameters
- Sets test name via plusargs and parameters for the new test
Reviewed Changes
| File | Description |
|---|---|
| src/mldsa_top/uvmf/uvmf_template_output/project_benches/mldsa/tb/tests/src/ML_DSA_randomized_h_decode_fail_test.yml | New YAML test configuration file for the verification failure test |
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/mldsa_top/uvmf/uvmf_template_output/project_benches/mldsa/tb/tests/src/ML_DSA_randomized_h_decode_fail_test.yml:3
- [nitpick] If the random seed is intended to make test results reproducible, consider either enabling this setting with additional documentation or removing the commented line to avoid confusion.
# seed: 4098270334
...e_output/project_benches/mldsa/tb/sequences/src/ML_DSA_randomized_h_decode_fail_sequence.svh
Show resolved
Hide resolved
Nitsirks
previously approved these changes
Mar 3, 2025
…alliance/adams-bridge into user/ekarabulut/MLDSA_verif_h_fail
mojtaba-bisheh
previously approved these changes
Mar 3, 2025
…il' with updated timestamp and hash after successful run
bharatpillilli
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.