-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom cops to Chefstyle #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many things we need to do project wide that are a lot easier to accomplish with rubocop cops. This copies of the scaffolding to do that from Cookstyle and add the shellout cop from cookstyle as well as a new cop. Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
reviewed
Aug 20, 2020
phiggins
reviewed
Aug 20, 2020
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
Use the new cop format and simplify how we extract the value Signed-off-by: Tim Smith <tsmith@chef.io>
CI is unhappy:
|
Removed in cookstyle as well where it's not being used. Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
There is no reason to do this. Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
reviewed
Aug 21, 2020
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
approved these changes
Aug 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Expeditor: Bump Version Minor
Used by github.minor_bump_labels to bump the Minor version number.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many things we need to do project wide that are a lot easier to accomplish with rubocop cops. This copies of the scaffolding to do that from Cookstyle and add the shellout cop from cookstyle as well as a new cop.
Note: these are at refactor level so they don't fail builds
TODO: tests
Signed-off-by: Tim Smith tsmith@chef.io