Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop to 0.83 #87

Merged
merged 1 commit into from
May 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions config/disable_all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ Layout/EmptyLinesAroundAccessModifier:
Enabled: false
Layout/EmptyLinesAroundArguments:
Enabled: false
Layout/EmptyLinesAroundAttributeAccessor:
Enabled: false
Layout/EmptyLinesAroundBeginBody:
Enabled: false
Layout/EmptyLinesAroundBlockBody:
Expand Down Expand Up @@ -697,6 +699,8 @@ Style/SingleLineBlockParams:
Enabled: false
Style/SingleLineMethods:
Enabled: false
Style/SlicingWithRange:
Enabled: false
Style/SpecialGlobalVars:
Enabled: false
Style/StabbyLambdaParentheses:
Expand Down
33 changes: 29 additions & 4 deletions config/upstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ AllCops:
- '**/*.watchr'
- '**/.irbrc'
- '**/.pryrc'
- '**/.simplecov'
- '**/buildfile'
- '**/Appraisals'
- '**/Berksfile'
Expand All @@ -53,6 +54,7 @@ AllCops:
- '**/Podfile'
- '**/Puppetfile'
- '**/Rakefile'
- '**/rakefile'
- '**/Snapfile'
- '**/Steepfile'
- '**/Thorfile'
Expand Down Expand Up @@ -375,6 +377,7 @@ Layout/ConditionPosition:
StyleGuide: '#same-line-condition'
Enabled: true
VersionAdded: '0.53'
VersionChanged: '0.83'

Layout/DefEndAlignment:
Description: 'Align ends corresponding to defs correctly.'
Expand Down Expand Up @@ -460,6 +463,12 @@ Layout/EmptyLinesAroundArguments:
Enabled: true
VersionAdded: '0.52'

Layout/EmptyLinesAroundAttributeAccessor:
Description: "Keep blank lines around attribute accessors."
StyleGuide: '#empty-lines-around-attribute-accessor'
Enabled: pending
VersionAdded: '0.83'

Layout/EmptyLinesAroundBeginBody:
Description: "Keeps track of empty lines around begin-end bodies."
StyleGuide: '#empty-lines-around-bodies'
Expand Down Expand Up @@ -1295,8 +1304,8 @@ Layout/TrailingWhitespace:
StyleGuide: '#no-trailing-whitespace'
Enabled: true
VersionAdded: '0.49'
VersionChanged: '0.55'
AllowInHeredoc: false
VersionChanged: '0.83'
AllowInHeredoc: true

#################### Lint ##################################
### Warnings
Expand All @@ -1316,13 +1325,15 @@ Lint/AmbiguousOperator:
StyleGuide: '#method-invocation-parens'
Enabled: true
VersionAdded: '0.17'
VersionChanged: '0.83'

Lint/AmbiguousRegexpLiteral:
Description: >-
Checks for ambiguous regexp literals in the first argument of
a method invocation without parentheses.
Enabled: true
VersionAdded: '0.17'
VersionChanged: '0.83'

Lint/AssignmentInCondition:
Description: "Don't use assignment in conditions."
Expand All @@ -1339,8 +1350,9 @@ Lint/BigDecimalNew:
Lint/BooleanSymbol:
Description: 'Check for `:true` and `:false` symbols.'
Enabled: true
Safe: false
VersionAdded: '0.50'
VersionChanged: '0.81'
VersionChanged: '0.83'

Lint/CircularArgumentReference:
Description: "Default values in optional keyword arguments and optional ordinal arguments should not refer back to the name of the argument."
Expand Down Expand Up @@ -1411,13 +1423,16 @@ Lint/EmptyInterpolation:
Lint/EmptyWhen:
Description: 'Checks for `when` branches with empty bodies.'
Enabled: true
AllowComments: true
VersionAdded: '0.45'
VersionChanged: '0.83'

Lint/EnsureReturn:
Description: 'Do not use return in an ensure block.'
StyleGuide: '#no-return-ensure'
Enabled: true
VersionAdded: '0.9'
VersionChanged: '0.83'

Lint/ErbNewArguments:
Description: 'Use `:trim_mode` and `:eoutvar` keyword arguments to `ERB.new`.'
Expand Down Expand Up @@ -1565,6 +1580,7 @@ Lint/ParenthesesAsGroupedExpression:
StyleGuide: '#parens-no-spaces'
Enabled: true
VersionAdded: '0.12'
VersionChanged: '0.83'

Lint/PercentStringArray:
Description: >-
Expand Down Expand Up @@ -1808,7 +1824,7 @@ Lint/UselessAccessModifier:
Description: 'Checks for useless access modifiers.'
Enabled: true
VersionAdded: '0.20'
VersionChanged: '0.47'
VersionChanged: '0.83'
ContextCreatingMethods: []
MethodCreatingMethods: []

Expand Down Expand Up @@ -2948,6 +2964,7 @@ Style/IfWithSemicolon:
StyleGuide: '#no-semicolon-ifs'
Enabled: true
VersionAdded: '0.9'
VersionChanged: '0.83'

Style/ImplicitRuntimeError:
Description: >-
Expand Down Expand Up @@ -3425,7 +3442,9 @@ Style/OptionalArguments:
of the argument list.
StyleGuide: '#optional-arguments'
Enabled: true
Safe: false
VersionAdded: '0.33'
VersionChanged: '0.83'

Style/OrAssignment:
Description: 'Recommend usage of double pipe equals (||=) where applicable.'
Expand Down Expand Up @@ -3730,6 +3749,12 @@ Style/SingleLineMethods:
VersionChanged: '0.19'
AllowIfMethodIsEmpty: true

Style/SlicingWithRange:
Description: 'Checks array slicing is done with endless ranges when suitable.'
Enabled: pending
VersionAdded: '0.83'
Safe: false

Style/SpecialGlobalVars:
Description: 'Avoid Perl-style global variables.'
StyleGuide: '#no-cryptic-perlisms'
Expand Down
2 changes: 1 addition & 1 deletion lib/chefstyle/version.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module Chefstyle
VERSION = "1.0.4".freeze
RUBOCOP_VERSION = "0.82.0".freeze
RUBOCOP_VERSION = "0.83.0".freeze
end