Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RuboCop 1.13 and remove Ruby 2.4 support #134

Merged
merged 2 commits into from
May 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .expeditor/verify.pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,6 @@ expeditor:

steps:

- label: run-chefstyle-and-specs-ruby-2.4
command:
- .expeditor/run_linux_tests.sh rake
expeditor:
executor:
docker:
image: ruby:2.4-buster

- label: run-chefstyle-and-specs-ruby-2.5
command:
- .expeditor/run_linux_tests.sh rake
Expand Down
2 changes: 1 addition & 1 deletion config/chefstyle.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
AllCops:
TargetRubyVersion: 2.4
TargetRubyVersion: 2.5
SuggestExtensions: false

#
Expand Down
2 changes: 2 additions & 0 deletions config/disable_all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,8 @@ Layout/MultilineOperationIndentation:
Enabled: false
Layout/ParameterAlignment:
Enabled: false
Layout/RedundantLineBreak:
Enabled: false
Layout/RescueEnsureAlignment:
Enabled: false
Layout/SpaceAfterColon:
Expand Down
10 changes: 10 additions & 0 deletions config/upstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1101,6 +1101,14 @@ Layout/ParameterAlignment:
# But it can be overridden by setting this parameter
IndentationWidth: ~

Layout/RedundantLineBreak:
Description: >-
Do not break up an expression into multiple lines when it fits
on a single line.
Enabled: false
InspectBlocks: false
VersionAdded: '1.13'

Layout/RescueEnsureAlignment:
Description: 'Align rescues and ensures correctly.'
Enabled: true
Expand Down Expand Up @@ -1380,6 +1388,8 @@ Lint/AmbiguousBlockAssociation:
StyleGuide: '#syntax'
Enabled: true
VersionAdded: '0.48'
VersionChanged: '1.13'
IgnoredMethods: []

Lint/AmbiguousOperator:
Description: >-
Expand Down
2 changes: 1 addition & 1 deletion lib/chefstyle/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true
module Chefstyle
VERSION = "1.7.5"
RUBOCOP_VERSION = "1.12.1"
RUBOCOP_VERSION = "1.13.0"
end