Content accumulator guard #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way we manipulate run contexts in resources, and resource event notifications, we need to ensure that we aren't accumulating the configuration file content multiple times when the `add_config` method is used.
|
👍 |
jtimberman
added a commit
that referenced
this pull request
Oct 22, 2015
…rendered-twice Content accumulator guard
| @@ -127,7 +127,7 @@ def add_config(product, content) | |||
| # foodcritic thinks we are accessing a node attribute | |||
| node.run_state[:ingredient_config_data] ||= {} # ~FC001 | |||
| node.run_state[:ingredient_config_data][product] ||= '' # ~FC001 | |||
| node.run_state[:ingredient_config_data][product] += content # ~FC001 | |||
| node.run_state[:ingredient_config_data][product] += content unless node.run_state[:ingredient_config_data][product].include?(content) # ~FC001 | |||
There was a problem hiding this comment.
I read this as we only allow recipes to set the content data for a product once during a client run. Would it be better to raise an exception (or at least a warning) so it doesn't silently bypass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way we manipulate run contexts in resources, and resource
event notifications, we need to ensure that we aren't accumulating the
configuration file content multiple times when the
add_configmethodis used.